Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty metrics.go file and method call #76257

Merged

Conversation

@johscheuer
Copy link
Contributor

commented Apr 8, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR removes a code part that is not used or has no functionality. The Register() function of the nodeipam module is called but does nothing. In the code the util/metrics module is called to actually register the metric(s) if the nodeipam module: https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/nodeipam/node_ipam_controller.go#L106

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

Hi @johscheuer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

/ok-to-test

@draveness

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Please squash the two commits into one. And ping approver after that. :)

@dims

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

/priority important-soon
/approve
/lgtm
/assign @bowei @gmarek

@dims

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 8, 2019

@johscheuer johscheuer force-pushed the johscheuer:remove-unused-nodeipam-code branch from 7b84b11 to 80d6b04 Apr 8, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 8, 2019

@johscheuer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

Rebased like @draveness mentioned

@dims

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 8, 2019

@draveness

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

/lgtm

@johscheuer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

/assign @smarterclayton @liggitt

Clayton, Jordan, i don't see the current approvers active any more in the project, can you please /approve?

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, johscheuer, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 440d086 into kubernetes:master Apr 16, 2019

18 checks passed

cla/linuxfoundation johscheuer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Context retired. Status moved to "pull-kubernetes-dependencies".
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@jberkus

This comment has been minimized.

Copy link

commented Apr 22, 2019

Hey, even if this is unused code, it should have a (very brief) relase note.

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Hey, even if this is unused code, it should have a (very brief) relase note.

No release note is needed for this, there are no user-facing changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.