Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reapply] Perform GCE log rotation check every 5 minutes #76352

Merged
merged 1 commit into from Apr 12, 2019

Conversation

@jpbetz
Copy link
Contributor

commented Apr 9, 2019

Per kubernetes/klog#55 (comment), reapply #72062 which was rolled back just before 1.14 was released due to the advanced audit test which has since been marked as flaky and is no longer blocking this change.

What this PR does / why we need it:

Reduce GCE log rotation check from 1 hour to every 5 minutes.  Rotation policy is unchanged (new day starts, log file size > 100MB).

/priority important-longterm
/area platform/gce
/kind cleanup
/sig gcp

cc @yuwenma @timstclair @wojtek-t @dims

@yuwenma

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Love this change.
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

@yuwenma: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

In response to this:

Love this change.
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpbetz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

/assign @yguo0905
Would you approve? Thanks!

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Approving based on discussion in kubernetes/klog#55

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuwenma

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Gentle ping.

@dims

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 11, 2019

@k8s-ci-robot k8s-ci-robot merged commit ae8a4fc into kubernetes:master Apr 12, 2019

18 checks passed

cla/linuxfoundation jpbetz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Context retired. Status moved to "pull-kubernetes-dependencies".
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.