Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add envs for CNI version. #76353

Merged
merged 1 commit into from Apr 11, 2019

Conversation

@Random-Liu
Copy link
Member

commented Apr 9, 2019

This is useful for validating new CNI versions, and quickly update CNI versions for CVEs like containernetworking/plugins#269.

/cc @cadmuxe

Signed-off-by: Lantao Liu lantaol@google.com

Does this PR introduce a user-facing change?:

Added `CNI_VERSION` and `CNI_SHA1` environment variables in kube-up.sh to configure CNI versions on GCE.
Add envs for CNI version.
Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@Random-Liu: GitHub didn't allow me to request PR reviews from the following users: cadmuxe.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This is useful for validating new CNI versions, and quickly update CNI versions for CVEs like containernetworking/plugins#269.

/cc @cadmuxe

Signed-off-by: Lantao Liu lantaol@google.com

Does this PR introduce a user-facing change?:

Added `CNI_VERSION` and `CNI_SHA1` environment variables in kube-up.sh to configure CNI versions on GCE.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xichengliudui

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

/test pull-kubernetes-integration

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 10, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 134ed2e into kubernetes:master Apr 11, 2019

17 checks passed

cla/linuxfoundation Random-Liu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@cadmuxe

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

@cadmuxe

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

/cc @MrHohn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.