Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup of e2e/framework/ingress #76361

Merged
merged 1 commit into from Apr 11, 2019

Conversation

@SataQiu
Copy link
Member

SataQiu commented Apr 10, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Small cleanup of e2e/framework/ingress

Which issue(s) this PR fixes:

Ref #75601

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@@ -38,7 +38,7 @@ import (
"k8s.io/klog"

apps "k8s.io/api/apps/v1"
"k8s.io/api/core/v1"
v1 "k8s.io/api/core/v1"

This comment has been minimized.

Copy link
@cblecker

cblecker Apr 11, 2019

Member

What's the need for this?

This comment has been minimized.

Copy link
@SataQiu

SataQiu Apr 11, 2019

Author Member

goimports does this now for performance reasons since the path uses a symlink and the import path isnt the real path.

Ref: #76337

@neolit123
Copy link
Member

neolit123 left a comment

thanks
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Apr 11, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot merged commit 305f718 into kubernetes:master Apr 11, 2019

18 checks passed

cla/linuxfoundation SataQiu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Context retired. Status moved to "pull-kubernetes-dependencies".
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.