Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
kubeadm: add support for ECDSA keys #76390
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:
Hi @rojkov. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
Sure, updated the note.
Also I guess the current code can be simplified a bit since duplicated functionality exists in
2 times, most recently
Apr 11, 2019
Overall this change lgtm.
I do think reducing the duplication would be a good idea.
I'm not sure that I would be comfortable with switching to ECDSA-only without having some type of transition period where we first allow ECDSA as an option, then switching the default but still allowing RSA as an option, then finally going ECDSA-only. This should probably be done through config rather than a feature flag, since it would require inverting the logic at some point.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing