Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and clean up e2e framework utils #76411

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@WanLinghao
Copy link
Member

commented Apr 11, 2019

/kind cleanup
It is part of issue #76206. This patch handles test/e2e/framework/pv_util.go file. This file is more than 1000 lines, I split them into two directories based on their functions.

NONE
Copy link
Member

left a comment

@WanLinghao thanks for the PR but we are looking for smaller cleanups.
please focus on breaking up your work into smaller PRs.

you can still rename this one and make the commit touch only a small subset of files.

/hold

Copy link
Member

left a comment

@WanLinghao thanks for the PR but we are looking for smaller cleanups.
please focus on breaking up your work into smaller PRs.

you can still rename this one and make the commit touch only a small subset of files.

/hold

@cblecker cblecker removed their request for review Apr 19, 2019
@timothysc timothysc added this to the v1.16 milestone Jun 28, 2019
@alejandrox1

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

Hi @WanLinghao any updates on this?

@josiahbjorgaard

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Hello! I'm a bug triage shadow for the 1.16 release cycle and considering this PR has not been updated for a long time, I'd like to check it's status. The code freeze is starting 29th August (about 2 weeks from now) and while there is plenty of time, we want to ensure that each PR has a chance to be merged on time.

As the PR is tagged for 1.16, is it still planned for this release?

@WanLinghao

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

@josiahbjorgaard, I will update this very soon.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timothysc, WanLinghao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@fejta-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@cblecker

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

/lgtm cancel
needs rebase

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 11, 2019
@WanLinghao WanLinghao force-pushed the WanLinghao:pv_refactor branch 4 times, most recently from 0efe2b9 to b5c5765 Sep 12, 2019
@WanLinghao

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

/test pull-kubernetes-conformance-kind-ipv6

@WanLinghao

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

@cblecker rebase done, PTAL

@WanLinghao

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@WanLinghao WanLinghao force-pushed the WanLinghao:pv_refactor branch 2 times, most recently from ff5ae07 to 74c9d2a Sep 17, 2019
Copy link
Contributor

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 17, 2019
@alejandrox1

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

Thank you again for working on this!
Hopefully we can get it in before any more rebases are required 😅

…e/framework/pv_util.go file
@WanLinghao WanLinghao force-pushed the WanLinghao:pv_refactor branch from 74c9d2a to a6f5d99 Sep 18, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 18, 2019
@WanLinghao

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2019

@alejandrox1 rebase again..PTAL

@alejandrox1

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Copy link
Contributor

left a comment

/lgtm
again 😅

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit b8d8f1a into kubernetes:master Sep 18, 2019
25 checks passed
25 checks passed
cla/linuxfoundation WanLinghao authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.