Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update benchmark-dockerized.sh and verify-dockerized.sh #76448

Merged

Conversation

Projects
None yet
3 participants
@xichengliudui
Copy link
Contributor

xichengliudui commented Apr 11, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 11, 2019

@xichengliudui: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xichengliudui

This comment has been minimized.

@k8s-ci-robot k8s-ci-robot requested review from cblecker and krzyzacy Apr 11, 2019

@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

xichengliudui commented Apr 11, 2019

/sig testing
/kind cleanup
/priority backlog
/release-note-none

@@ -57,4 +57,4 @@ cd /go/src/k8s.io/kubernetes
make test-integration WHAT="$*" KUBE_TEST_ARGS="-run='XXX' -bench=. -benchmem" \
| tee \
>(prettybench -no-passthrough > "${ARTIFACTS}/BenchmarkResults.txt") \
>(go run test/integration/benchmark/jsonify/main.go "${ARTIFACTS}"/BenchmarkResults_benchmark_"$(date -u +%Y-%m-%dT%H:%M:%SZ)".json || cat > /dev/null)
>(go run test/integration/benchmark/jsonify/main.go "${ARTIFACTS}/BenchmarkResults_benchmark_""$(date -u +%Y-%m-%dT%H:%M:%SZ)".json || cat > /dev/null)

This comment has been minimized.

Copy link
@cblecker

cblecker Apr 11, 2019

Member
Suggested change
>(go run test/integration/benchmark/jsonify/main.go "${ARTIFACTS}/BenchmarkResults_benchmark_""$(date -u +%Y-%m-%dT%H:%M:%SZ)".json || cat > /dev/null)
>(go run test/integration/benchmark/jsonify/main.go "${ARTIFACTS}/BenchmarkResults_benchmark_$(date -u +%Y-%m-%dT%H:%M:%SZ).json" || cat > /dev/null)

This comment has been minimized.

Copy link
@xichengliudui

xichengliudui Apr 12, 2019

Author Contributor

YES, has been updated.

@xichengliudui xichengliudui force-pushed the xichengliudui:fixshellcheckfailures-20 branch from ca968d8 to 037729b Apr 12, 2019

@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

xichengliudui commented Apr 12, 2019

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot requested a review from cblecker Apr 13, 2019

@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

xichengliudui commented Apr 13, 2019

/cc @cblecker, has been updated.

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Apr 13, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, xichengliudui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 92918dc into kubernetes:master Apr 13, 2019

18 checks passed

cla/linuxfoundation xichengliudui authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.