Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ExecMount to pkg/volume/util/exec #76456

Merged
merged 2 commits into from Apr 17, 2019

Conversation

@codenrhoden
Copy link
Member

commented Apr 11, 2019

What type of PR is this?
/kind cleanup
/sig storage
/assign @msau42 @jsafrane @ddebroy

What this PR does / why we need it:
This patch moves the ExecMounter found in pkg/util/mount to
pkg/volume/util/exec. This is done in preparation for pkg/util/mount to
move out of tree. This specific implementation of mount.Interface is only
used internally to K8s and does not need to move out of tree.

Which issue(s) this PR fixes:

Special notes for your reviewer:
This is another step in making #68513 be a lot simpler.

Does this PR introduce a user-facing change?:

NONE
Move ExecMount to pkg/volume/util/exec
This patch moves the ExecMounter found in pkg/util/mount to
pkg/volume/util/exec. This is done in preparation for pkg/util/mount to
move out of tree. This specific implemention of mount.Interface is only
used internally to K8s and does not need to move out of tree.
@codenrhoden

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

/retest

@codenrhoden

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@codenrhoden

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

/retest

1 similar comment
@codenrhoden

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

/retest

@codenrhoden

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@dims

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 15, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

/priority important-soon

@msau42

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 15, 2019

@saad-ali
Copy link
Member

left a comment

/approve

For LGTM:
/assign @jsafrane

@dims

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@codenrhoden

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

/hold

putting on a hold in case final approval comes through before an LGTM from Jan.

@jsafrane

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

/approve
/hold cancel

Thanks for this PR!

@codenrhoden

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

Awesome! I've contacted three kubelet approvers on Slack -- hopefully one is around today to take a quick look at this one.

@tallclair
Copy link
Member

left a comment

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden, jsafrane, msau42, saad-ali, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 32a4982 into kubernetes:master Apr 17, 2019

18 checks passed

cla/linuxfoundation codenrhoden authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@codenrhoden codenrhoden deleted the codenrhoden:mv-exec-mounter branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.