Update klog to 0.3.0 #76474

vincepri · 2019-04-11T23:01:07Z

Signed-off-by: Vince Prignano vincepri@vmware.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR updates klog dependency to the latest release: 0.3.0.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Updated klog to 0.3.0

dims · 2019-04-11T23:07:19Z

/approve
/assign @liggitt @cblecker

liggitt · 2019-04-12T01:49:11Z

cmd/kubelet/app/options/globalflags.go

@@ -105,6 +105,7 @@ func addGlogFlags(fs *pflag.FlagSet) {
 	register(global, local, "log_backtrace_at")
 	register(global, local, "log_dir")
 	register(global, local, "log_file")
+	register(global, local, "log_file_max_size")


is it our intent to keep adding global flags like this? I expected us to manage flags in a better way going forward, especially if we control the log library

Honestly I'm not sure. I updated the code where the codebase is referenced, I can take this one out I think, but the other change in components-base is required otherwise some tests fail.

To be clear, the issue is with the change made in klog, but this change here is a good example of the further pollution of the global flag space it is causing. Before we pull it into kubernetes, we should resolve the future direction of klog flag handling.

@liggitt please see kubernetes/klog#56 and kubernetes/klog#55 we can continue the conversation there

vincepri · 2019-04-18T03:40:31Z

/retest

staging/src/k8s.io/component-base/logs/logs.go

Signed-off-by: Vince Prignano <vincepri@vmware.com>

vincepri · 2019-04-18T15:53:23Z

/retest

vincepri · 2019-04-18T16:57:58Z

@dims @liggitt All tests passed 🎉, ptal

liggitt · 2019-04-18T17:06:14Z

/lgtm
/approve

k8s-ci-robot · 2019-04-18T17:06:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

liggitt · 2019-04-18T18:01:33Z

/hold cancel

mtaufen · 2019-05-07T21:27:36Z

FYI it looks like this may have broken Kubelet's log to file behavior: #77416

@yujuhong mentioned it now writes to the log file up to the point where it tries to load the Kubelet config file, then starts logging to stderr afterwards. This makes me wonder if there is some nefarious interaction between how klog registers its flags and the way we currently enforce flag precedence.

mtaufen · 2019-05-07T21:39:46Z

@liggitt @vincepri

I think the issue is that this PR changes the global FlagSet construction logic to call klog.InitFlags every time a new FlagSet is constructed. This has the side effect of resetting the values of all klog flags to defaults. The old logic constructed a FlagSet that referenced the global flags without changing their values.

Constructing the global flag set should not have such a side-effect, because the Kubelet currently needs to re-parse the full command line to enforce precedence while explicitly not calling Set for global flag values a second time, or else accumulator flags could end up with duplicate entries during the re-parse.

dims · 2019-05-07T21:41:58Z

@mtaufen also see #77305 could that be the same problem you are describing above?

mtaufen · 2019-05-07T21:43:52Z

staging/src/k8s.io/component-base/cli/globalflag/globalflags.go

+// addKlogFlags adds flags from k8s.io/klog
+func addKlogFlags(fs *pflag.FlagSet) {
+	local := flag.NewFlagSet(os.Args[0], flag.ExitOnError)
+	klog.InitFlags(local)


This has the side effect of resetting the values in klog to defaults every time a new flagset is constructed.

mtaufen · 2019-05-07T21:48:29Z

@dims I believe the problem I described only happens in the Kubelet; I don't think any other components have copied the flag precedence approach in the Kubelet yet (hence the legacyflag work). That said, if other components wanted to do something similar, a similar call to InitFlags in the globalflag package in component-base will cause the same issue.

I think we should be able to fix by just reverting the Kubelet code to register each klog flag individually, and avoid the side-effect.

mtaufen · 2019-05-07T21:50:30Z

Alternatively, we could revert this PR, then fix klog so that InitFlags itself is free of global side-effects.

mtaufen · 2019-05-07T22:02:14Z

Former fix: #77562

vincepri · 2019-05-07T22:03:28Z

I'll defer to @liggitt and @dims on path forward, happy to put in some time for a fix if needed

dims · 2019-05-08T16:29:01Z

@mtaufen thanks!

@vincepri looks like @mtaufen has filed the fix for "reverting the Kubelet code", can you please do the other one? " register each klog flag individually " Thanks!

mtaufen · 2019-05-08T17:13:29Z

@vincepri FYI reverting the Kubelet code == registering each klog flag individually. The other one was "fix klog so that InitFlags itself is free of global side-effects."

k8s-ci-robot requested review from caesarxuchao, davidopp and a team April 11, 2019 23:01

k8s-ci-robot assigned cblecker and liggitt Apr 11, 2019

dims approved these changes Apr 11, 2019

View reviewed changes

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2019

vincepri force-pushed the update-klog-030 branch from 90977ca to 40290d8 Compare April 11, 2019 23:56

liggitt reviewed Apr 12, 2019

View reviewed changes

vincepri force-pushed the update-klog-030 branch 4 times, most recently from 861b6c4 to 2d63c92 Compare April 18, 2019 15:08

liggitt reviewed Apr 18, 2019

View reviewed changes

staging/src/k8s.io/component-base/logs/logs.go Outdated Show resolved Hide resolved

Update klog to 0.3.0

3f55226

Signed-off-by: Vince Prignano <vincepri@vmware.com>

vincepri force-pushed the update-klog-030 branch from 2d63c92 to 3f55226 Compare April 18, 2019 15:33

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2019

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2019

k8s-ci-robot merged commit 17fe18b into kubernetes:master Apr 18, 2019

yujuhong mentioned this pull request May 3, 2019

Windows/GCE: kubelet does not write logs to file properly #77416

Closed

mtaufen reviewed May 7, 2019

View reviewed changes

mtaufen mentioned this pull request May 7, 2019

Fix addKlogFlags in global flag libs #77562

Closed

vincepri mentioned this pull request May 21, 2019

Set default values only once kubernetes/klog#66

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update klog to 0.3.0 #76474

Update klog to 0.3.0 #76474

vincepri commented Apr 11, 2019 •

edited

dims commented Apr 11, 2019

liggitt Apr 12, 2019 •

edited

vincepri Apr 12, 2019

liggitt Apr 12, 2019

liggitt Apr 12, 2019

dims Apr 12, 2019

vincepri commented Apr 18, 2019

vincepri commented Apr 18, 2019

vincepri commented Apr 18, 2019

liggitt commented Apr 18, 2019

k8s-ci-robot commented Apr 18, 2019

liggitt commented Apr 18, 2019

mtaufen commented May 7, 2019

mtaufen commented May 7, 2019

dims commented May 7, 2019

mtaufen May 7, 2019

mtaufen commented May 7, 2019

mtaufen commented May 7, 2019

mtaufen commented May 7, 2019

vincepri commented May 7, 2019

dims commented May 8, 2019

mtaufen commented May 8, 2019

Update klog to 0.3.0 #76474

Update klog to 0.3.0 #76474

Conversation

vincepri commented Apr 11, 2019 • edited

dims commented Apr 11, 2019

liggitt Apr 12, 2019 • edited

Choose a reason for hiding this comment

vincepri Apr 12, 2019

Choose a reason for hiding this comment

liggitt Apr 12, 2019

Choose a reason for hiding this comment

liggitt Apr 12, 2019

Choose a reason for hiding this comment

dims Apr 12, 2019

Choose a reason for hiding this comment

vincepri commented Apr 18, 2019

vincepri commented Apr 18, 2019

vincepri commented Apr 18, 2019

liggitt commented Apr 18, 2019

k8s-ci-robot commented Apr 18, 2019

liggitt commented Apr 18, 2019

mtaufen commented May 7, 2019

mtaufen commented May 7, 2019

dims commented May 7, 2019

mtaufen May 7, 2019

Choose a reason for hiding this comment

mtaufen commented May 7, 2019

mtaufen commented May 7, 2019

mtaufen commented May 7, 2019

vincepri commented May 7, 2019

dims commented May 8, 2019

mtaufen commented May 8, 2019

vincepri commented Apr 11, 2019 •

edited

liggitt Apr 12, 2019 •

edited