Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix older bash failing on unbound array variables #76495

Merged
merged 1 commit into from Apr 15, 2019

Conversation

@h00130372
Copy link
Contributor

h00130372 commented Apr 12, 2019

Fix older bash failing on unbound array variables

Older bash versions fail when trying to expand array variables
when the array is empty.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 12, 2019

@h00130372: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 12, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 12, 2019

Hi @h00130372. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@h00130372

This comment has been minimized.

Copy link
Contributor Author

h00130372 commented Apr 12, 2019

I have signed the cla

Show resolved Hide resolved hack/local-up-cluster.sh Outdated

@cblecker cblecker self-assigned this Apr 13, 2019

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Apr 13, 2019

/ok-to-test

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Apr 13, 2019

@h00130372 The CLA system is still reporting that you haven't signed the CLA. Can you check if you've followed all the steps outlined in #76495 (comment)?

Fix older bash failing on unbound array variables
Older bash versions fail when trying to expand array variables
when the array is empty.

@h00130372 h00130372 force-pushed the h00130372:fix-unbound-variable branch from c57d2c5 to de95a33 Apr 15, 2019

@h00130372

This comment has been minimized.

Copy link
Contributor Author

h00130372 commented Apr 15, 2019

@cblecker, sorry I checked again, and now it's authorized :)

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Apr 15, 2019

/lgtm
/approve
/release-note-none
/priority backlog
/sig testing
/kind cleanup

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, h00130372

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Apr 15, 2019

Thanks for the fix 🚀

@k8s-ci-robot k8s-ci-robot merged commit 76b877a into kubernetes:master Apr 15, 2019

19 of 20 checks passed

tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation h00130372 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.