Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix TestEventChannelFull random fail #76603
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Hi @changyaowei. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
mattjmcnaughton left a comment
My one question is why we aren't seeing more consistent flakes because of this? Is it because, while Golang doesn't guarantee the ordering when iterating through a dictionary, it is "in practice" reproducible?
I think this change makes sense either way, I just want to be sure I'm understanding why we haven't been seeing more flakes.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing