Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress registering GCE LB provider flag if missing on CommandLine. #76627

Conversation

@timoreimann
Copy link
Contributor

commented Apr 15, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes an issue with the GCE-specific cloud-provider-gce-lb-src-cidrs flag being added by default that breaks external cloud providers.

Which issue(s) this PR fixes:
Fixes #76205

Does this PR introduce a user-facing change?:

GCE-only flag `cloud-provider-gce-lb-src-cidrs` becomes optional for external cloud providers.

/sig cloud-provider

Verified on DigitalOcean's CCM currently being updated to 1.14.1.

/cc @dims @andrewsykim

Suppress registering GCE LB provider flag if missing on CommandLine.
Fixes an issue with GCE-specific parameters breaking out-of-tree cloud
providers that do not host the flag in question.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Hi @timoreimann. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewsykim

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

/ok-to-test

// the gce cloudprovider is removed.
globalflag.Register(namedFlagSets.FlagSet("generic"), "cloud-provider-gce-lb-src-cidrs")

if flag.CommandLine.Lookup("cloud-provider-gce-lb-src-cidrs") != nil {

This comment has been minimized.

Copy link
@andrewsykim

andrewsykim Apr 15, 2019

Member

cc @cheftako @mikedanese this was breaking implementations that didn't import the GCE provider

@andrewsykim

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

/approve
/lgtm
/hold

/assign @cheftako @mikedanese

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, timoreimann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewsykim

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

/priority important-soon

@timoreimann

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

/retest

@andrewsykim

This comment has been minimized.

Copy link
Member

commented May 4, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit e1fa195 into kubernetes:master May 4, 2019

19 of 20 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation timoreimann authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@timoreimann timoreimann deleted the timoreimann:handle-missing-gce-lb-flag-gracefully branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.