Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Output missing cert or key name in DownloadCerts #76636
Otherwise the user does not know what key
What type of PR is this?
What this PR does / why we need it:
It improves the error message when
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Hi @mdaniel. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
fabriziopandini left a comment •
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
@fabriziopandini thank you for shepherding this change through so quickly; that's in stark contrast to a lot of my other open source experiences. I am sincerely grateful for your help.
I am a big fan of attaching labels to the text, rather than an implied formatting, but if you feel that another format would be more in alignment with what users would expect, or there is precedent for doing that elsewhere in
the path already includes the file name.
@mdaniel could you please change this to: