Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to instance-level update APIs for Azure VMSS loadbalancer operations #76656

Merged
merged 5 commits into from Apr 22, 2019

Conversation

@feiskyer
Copy link
Member

commented Apr 16, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug

What this PR does / why we need it:

Previously, VMSS API doesn't support configurations for each instance. Hence, Azure cloud provider upgrades manually for all instances whenever loadbalancer backend pools need to be updated. This would cause all instances restarted if there're also some other VMSS model changes.

To fix this issue, the PR switches to instance-level update APIs for Azure VMSS loadbalancer operations. It also upgrades Azure SDK to v21.4.0.

Which issue(s) this PR fixes:

Fixes #71594

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Switch to instance-level update APIs for Azure VMSS loadbalancer operations

/sig azure
/kind bug
/priority important-soon

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

@andyzhangx Addressed comments. PTAL

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

@feiskyer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 32343be link /test pull-kubernetes-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

/retest

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

pull-kubernetes-e2e-aks-engine-azure passed now.

/hold cancel

@andyzhangx
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 22, 2019

@k8s-ci-robot k8s-ci-robot merged commit f0a4672 into kubernetes:master Apr 22, 2019

21 checks passed

cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

Provider Azure automation moved this from Needs Review to Done Apr 22, 2019

@feiskyer feiskyer deleted the feiskyer:az-vmss-fix branch Apr 22, 2019

k8s-ci-robot added a commit that referenced this pull request Apr 27, 2019
Merge pull request #76994 from feiskyer/cherry-pick-76656-to-1.12
Automated cherry pick of #76656: Switch to instance-level update APIs for Azure VMSS loadbalancer operations
k8s-ci-robot added a commit that referenced this pull request Apr 27, 2019
Merge pull request #77069 from feiskyer/cherry-pick-76656-to-1.11
Automated cherry pick of #76656: Switch to instance-level update APIs for Azure VMSS loadbalancer operations
k8s-ci-robot added a commit that referenced this pull request May 2, 2019
Merge pull request #76992 from feiskyer/cherry-pick-76656-to-1.14
Automated cherry pick of #76656: Switch to instance-level update APIs for Azure VMSS loadbalancer operations
k8s-ci-robot added a commit that referenced this pull request May 3, 2019
Merge pull request #76993 from feiskyer/cherry-pick-76656-to-1.13
Automated cherry pick of #76656: Switch to instance-level update APIs for Azure VMSS loadbalancer operations
@feiskyer feiskyer referenced this pull request May 29, 2019
12 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.