Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shellcheck failures on test-e2e-node.sh and test-integration.sh #76744

Merged

Conversation

@xichengliudui
Copy link
Contributor

commented Apr 18, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Ref #75912

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

/priority important-soon
/sig testing

fi
echo "Test artifacts will be written to ${artifacts}"

if [[ ${runtime} == "remote" ]] ; then
if [[ ! -z ${container_runtime_endpoint} ]] ; then
if [[ -n ${container_runtime_endpoint} ]] ; then

This comment has been minimized.

Copy link
@xichengliudui

xichengliudui Apr 18, 2019

Author Contributor

Why did it change and what did it fix:

In ./hack/make-rules/test-e2e-node.sh line 65:
  if [[ ! -z ${container_runtime_endpoint} ]] ; then
        ^-- SC2236: Use -n instead of ! -z.
Ref: https://github.com/koalaman/shellcheck/wiki/SC2236
@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

/assign @fejta

@fejta
Copy link
Contributor

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, xichengliudui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f0022d8 into kubernetes:master Apr 19, 2019

20 checks passed

cla/linuxfoundation xichengliudui authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.