Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golint failures of pkg/kubelet/apis #76763

Merged
merged 1 commit into from Apr 24, 2019

Conversation

@SataQiu
Copy link
Member

commented Apr 18, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix golint failures of pkg/kubelet/apis

Which issue(s) this PR fixes:

Ref #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@mattjmcnaughton
Copy link
Contributor

left a comment

Thanks for your pr :)

It looks like the verify-golint check is still failing bc of:

Errors from golint:
pkg/kubelet/apis/well_known_annotations_windows.go:30:2: exported const HypervIsolationValue should have comment (or a comment on this block) or be unexported

Otherwise, lgtm. Will add lgtm label after the final error is correct.

@SataQiu SataQiu force-pushed the SataQiu:ifx-golint-kubelet-20190419 branch from 4f0c59b to 2944c7d Apr 18, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Apr 18, 2019

@SataQiu

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

/test pull-kubernetes-e2e-gce

@mattjmcnaughton
Copy link
Contributor

left a comment

/lgtm

thanks for your work on these lint errors :)

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 19, 2019

@SataQiu

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

/assign @yujuhong @fejta

@fejta
Copy link
Contributor

left a comment

/approve

@SataQiu

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

Can you review this PR? @yujuhong

@fejta
Copy link
Contributor

left a comment

/lgtm
/approve

@SataQiu

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

Can you review this PR? @yujuhong @Random-Liu

@SataQiu

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

/assign @liggitt

@@ -27,7 +27,10 @@ const (
// The OS/Arch labels are promoted to GA in 1.14. kubelet applies both beta
// and GA labels to ensure backward compatibility.
// TODO: stop applying the beta OS/Arch labels in Kubernetes 1.18.
LabelOS = "beta.kubernetes.io/os"

// LabelOS is a label to indicate the operating system of the node.

This comment has been minimized.

Copy link
@liggitt

liggitt Apr 24, 2019

Member

Keep the comments about backward compatibility and the release they will no longer be applied associated with the variables

This comment has been minimized.

Copy link
@SataQiu

SataQiu Apr 24, 2019

Author Member

Thank you very much! @liggitt
I have updated the code.

@SataQiu SataQiu force-pushed the SataQiu:ifx-golint-kubelet-20190419 branch from 2944c7d to 828125c Apr 24, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 24, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 24, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, liggitt, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5a790bc into kubernetes:master Apr 24, 2019

20 checks passed

cla/linuxfoundation SataQiu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.