Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soltysh and pwittrock to sig-cli-api-reviewers #76816

Merged
merged 1 commit into from Apr 19, 2019

Conversation

Projects
None yet
3 participants
@soltysh
Copy link
Contributor

commented Apr 19, 2019

What type of PR is this?
/kind cleanup
/priority important-soon
/sig cli

What this PR does / why we need it:
Update SIG-CLI API approvers

Special notes for your reviewer:
/assign @liggitt
@pwittrock fyi

Does this PR introduce a user-facing change?:

NONE

@soltysh soltysh force-pushed the soltysh:cli_apiapprovers branch from 9f6103e to 9870475 Apr 19, 2019

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/M labels Apr 19, 2019

@soltysh soltysh changed the title Add soltysh and pwittrock to sig-cli-api-approvers Add soltysh and pwittrock to sig-cli-api-reviewers Apr 19, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 19, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 61fa0fd into kubernetes:master Apr 19, 2019

20 checks passed

cla/linuxfoundation soltysh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@soltysh soltysh deleted the soltysh:cli_apiapprovers branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.