Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics-server addon] Restore connecting to nodes via IP addresses #76819

Merged

Conversation

@serathius
Copy link
Contributor

commented Apr 19, 2019

This preference list matches is used to pick prefered field from k8s
node object. It was introduced in metrics-server 0.3 and changed default
behaviour to use DNS instead of IP addresses. It was merged into k8s
1.12 and caused breaking change by introducing dependency on DNS
configuration.

/assign @x13n
/cc @DirectXMan12
/sig instrumentation

[metrics-server addon] Restore connecting to nodes via IP addresses
[metrics-server addon] Restore metrics-server using of IP addresses
This preference list matches is used to pick prefered field from k8s
node object. It was introduced in metrics-server 0.3 and changed default
behaviour to use DNS instead of IP addresses. It was merged into k8s
1.12 and caused breaking change by introducing dependency on DNS
configuration.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

Hi @serathius. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kawych

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

/ok-to-test
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug and removed needs-kind labels Apr 19, 2019

@k8s-ci-robot k8s-ci-robot merged commit b32b742 into kubernetes:master Apr 19, 2019

20 checks passed

cla/linuxfoundation serathius authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

k8s-ci-robot added a commit that referenced this pull request Apr 26, 2019

Merge pull request #76830 from serathius/automated-cherry-pick-of-#76…
…819-upstream-release-1.13

Automated cherry pick of #76819: Restore metrics-server using of IP

k8s-ci-robot added a commit that referenced this pull request Apr 26, 2019

Merge pull request #76831 from serathius/automated-cherry-pick-of-#76…
…819-upstream-release-1.12

Automated cherry pick of #76819: Restore metrics-server using of IP

k8s-ci-robot added a commit that referenced this pull request Apr 26, 2019

Merge pull request #76829 from serathius/automated-cherry-pick-of-#76…
…819-upstream-release-1.14

Automated cherry pick of #76819: Restore metrics-server using of IP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.