Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a kubemark panic when hollow-node is morphed as proxy #76848

Merged
merged 1 commit into from Apr 23, 2019

Conversation

@Huang-Wei
Copy link
Member

commented Apr 19, 2019

What type of PR is this?

/kind bug
/sig scalability
/assign @shyamjvs @wojtek-t

What this PR does / why we need it:

Kubemark is used widely in perf tests of control plane components such as apiserver, scheduler, etc. But recently I found it paniced when morphed as proxy.

Another solution is to use os/exec to lookup the real path, but it doesn't work b/c of other fake objs, in particular it will panic again at:

panic(fmt.Sprintf("ran out of Command() actions. Could not handle command [%d]: %s args: %v", fake.CommandCalls, cmd, args))

Which issue(s) this PR fixes:

Fixes #69735.

Special notes for your reviewer:

I haven't figured out from which release kubemark started not to function.

Updated: this issue exists in v1.12.7.

Does this PR introduce a user-facing change?:

Fixed a kubemark panic when hollow-node is morphed as proxy.
@Huang-Wei

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

/retest

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 23, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ccf9556 into kubernetes:master Apr 23, 2019

20 checks passed

cla/linuxfoundation Huang-Wei authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@Huang-Wei Huang-Wei deleted the Huang-Wei:fix-kubemark-proxy branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.