Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gem versions #76854

Merged
merged 1 commit into from May 11, 2019

Conversation

@ialidzhikov
Copy link
Contributor

commented Apr 20, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature

/kind flake

What this PR does / why we need it:
Updates the fluentd image gem versions and allow image users to use the configs introduced in the latest versions. For example uken/fluent-plugin-elasticsearch#579 .

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2019

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from coffeepac and piosz Apr 20, 2019

@coffeepac

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

/ok-to-test
/Approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coffeepac, ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Update gem versions
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>

@ialidzhikov ialidzhikov force-pushed the ialidzhikov:update-images branch from 920d8b6 to becbed8 May 1, 2019

@ialidzhikov

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Hm, the lgtm label is missing. Any updates?

@coffeepac

This comment has been minimized.

Copy link
Member

commented May 10, 2019

/lgtm

apologies for the slow response and thanks for pinging!

@k8s-ci-robot k8s-ci-robot added the lgtm label May 10, 2019

@k8s-ci-robot k8s-ci-robot merged commit 5669014 into kubernetes:master May 11, 2019

20 checks passed

cla/linuxfoundation ialidzhikov authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@ialidzhikov

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@coffeepac , did you managed to push the new v2.5.2 image?

$ docker pull gcr.io/fluentd-elasticsearch/fluentd:v2.5.2
Error response from daemon: manifest for gcr.io/fluentd-elasticsearch/fluentd:v2.5.2 not found

https://console.cloud.google.com/gcr/images/fluentd-elasticsearch/GLOBAL/fluentd

@coffeepac

This comment has been minimized.

Copy link
Member

commented May 13, 2019

@coffeepac

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@ialidzhikov pushed. sorry for the delay!

@ialidzhikov

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@coffeepac , thank you!

@monotek

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Thanks! Updated helm chart is also available soon :-)
kiwigrid/helm-charts#104

@ialidzhikov ialidzhikov deleted the ialidzhikov:update-images branch May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.