Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook admission tests: connect, proxy, binding, eviction #76910

Merged
merged 3 commits into from Apr 23, 2019

Conversation

@liggitt
Copy link
Member

commented Apr 22, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Adds integration tests for webhook admission for:

  • pod connect subresources (exec, attach, portforward)
  • pod/service/node proxy subresources
  • pod binding/eviction subresources (and fixes validating admission calls for those requests)

Which issue(s) this PR fixes:
xref #76907
fixes #75193

Does this PR introduce a user-facing change?:

Validating admission webhooks are now properly called for CREATE operations on the following resources: pods/binding, pods/eviction, bindings

/cc @caesarxuchao @sbezverk

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt changed the title Test webhook admission - pod connect subresources webhook admission tests: connect, proxy, binding, eviction Apr 23, 2019

@liggitt liggitt force-pushed the liggitt:pod-admission branch from f94fbbc to 25753d6 Apr 23, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

/retest

@liggitt liggitt force-pushed the liggitt:pod-admission branch 2 times, most recently from a13114a to aadc270 Apr 23, 2019

@liggitt liggitt force-pushed the liggitt:pod-admission branch from aadc270 to a4576ec Apr 23, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

/retest

@sbezverk

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

/lgtm

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 90fbbee into kubernetes:master Apr 23, 2019

20 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:pod-admission branch Apr 23, 2019

@liggitt liggitt added this to Complete in Admission Webhooks Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.