Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update golang.org/x/oauth2 #76914

Merged
merged 1 commit into from Apr 24, 2019

Conversation

@tsuna
Copy link
Contributor

commented Apr 22, 2019

Pick up the bug fix for golang/oauth2#237

This commit was generated by:

./hack/pin-dependency.sh golang.org/x/oauth2 9f3314589c9a
./hack/update-vendor.sh
git add vendor
git add -u

Fixes #76908

/sig auth
/kind bug

Does this PR introduce a user-facing change?:

Fix OpenID Connect (OIDC) token refresh when the client secret contains a special character.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • ebe2505 vendor: update golang.org/x/oauth2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Hi @tsuna. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsuna

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

/assign ericchiang

@ericchiang

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Approving for impact on OpenID Connect kubectl auth provider.

/approve

@WanLinghao

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

/ok-to-test

@liggitt liggitt self-assigned this Apr 23, 2019

go.mod Show resolved Hide resolved
vendor: update golang.org/x/oauth2 and cloud.google.com/go
Pick up the bug fix for golang/oauth2#237
Bump up cloud.google.com/go as a result of updating the OAuth2 code.

This commit was generated by:
./hack/pin-dependency.sh golang.org/x/oauth2 9f3314589c9a
./hack/pin-dependency.sh cloud.google.com/go v0.34.0
./hack/update-vendor.sh
git add vendor
git add -u

@tsuna tsuna force-pushed the tsuna:master branch from fa527f8 to ef492e2 Apr 23, 2019

@tsuna

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

Thanks guys for the quick review, much appreciated! As per @liggitt's comment, I bumped up cloud.google.com/go as well.
./hack/verify-vendor.sh passes.

@dims

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

/approve
/hold

(hold for @liggitt 's review)

@dims

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

/priority important-soon

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

/lgtm
/approve

thanks

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 23, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

/hold cancel

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ericchiang, liggitt, tsuna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsuna

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

Looks like a timeout that's not related to this change.
/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 219b166 into kubernetes:master Apr 24, 2019

20 checks passed

cla/linuxfoundation tsuna authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.