Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Remove hyperkube short aliases #76953

Merged
merged 2 commits into from May 8, 2019

Conversation

@Rand01ph
Copy link
Contributor

commented Apr 23, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove hyperkube short aliases

Which issue(s) this PR fixes:

Fixes #69896

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove hyperkube short aliases from source code, Because hyperkube docker image currently create these aliases. [action required] If you are currently using /hyperkube {apiserver,scheduler,controller-manager,proxy} please switch to using the correct binary names.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Hi @Rand01ph. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rand01ph

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

Signed the CLA

@dims

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

/ok-to-test
/approve
/lgtm

@dims

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

/priority important-soon
/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 24, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

/assign @thockin

@mikedanese

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

/approve

@Rand01ph

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

@Rand01ph: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e f6bf44a link /test pull-kubernetes-local-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@luxas
luxas approved these changes May 8, 2019
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 8, 2019

@dims

This comment has been minimized.

Copy link
Member

commented May 8, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 0ff81d0 into kubernetes:master May 8, 2019

19 of 20 checks passed

pull-kubernetes-local-e2e Job failed.
Details
cla/linuxfoundation Rand01ph authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

SIG Release automation moved this from Backlog to Done May 8, 2019

adelina-t added a commit to adelina-t/aks-engine that referenced this pull request May 10, 2019
Update hyperkube command in manifests for k8s components.
In k8s 1.15 this PR : kubernetes/kubernetes#76953
removed aliases for k8s binaries in hyperkube ( i.e proxy alias for kube-proxy ).

This PR changes the commands in all manifests that invoke hyperkube
to use the full name of the binaries.
jackfrancis added a commit to Azure/aks-engine that referenced this pull request May 10, 2019
fix: update short hyperkube commands in manifests for k8s components (#…
…1279)

In k8s 1.15 this PR : kubernetes/kubernetes#76953
removed aliases for k8s binaries in hyperkube ( i.e proxy alias for kube-proxy ).

This PR changes the commands in all manifests that invoke hyperkube
to use the full name of the binaries.
@alvaroaleman

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Any chance we can make the release note a bit more explicit? This pr removes the /hyperkube {apiserver,scheduler,controller-manager} commands, this is definitely an [action required] for anyone who uses those.

Also it would be nice if we deprecated the flags themselves next time instead of a command that creates a symlink for them 🙃

@dims

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

@alvaroaleman wanna file a PR for the second part? Also i updated the release note and tacked on your suggestion to the end. Please do propose an alternative if this does not read better and i'll happily update it.

@alvaroaleman

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

@dims thanks for updating the release note, looks much better now! What do you mean by "wanna file a PR for the second part?", for what can I file a PR there?

@dims

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

@alvaroaleman from your statement "we deprecated the flags themselves" i thought i missed something which needed another PR. that's what i was referring to. thanks!

mohitevishal added a commit to vmware/ansible-coreos-kubernetes-minion that referenced this pull request Sep 17, 2019
mohitevishal added a commit to vmware/ansible-coreos-kubernetes-master that referenced this pull request Sep 17, 2019
mohitevishal added a commit to vmware/ansible-coreos-kubernetes-master that referenced this pull request Sep 18, 2019
mohitevishal added a commit to vmware/ansible-coreos-kubernetes-master that referenced this pull request Sep 18, 2019
mohitevishal added a commit to vmware/ansible-coreos-kubernetes-minion that referenced this pull request Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.