Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eviction dry-run #76969

Merged
merged 1 commit into from Apr 25, 2019

Conversation

@apelisse
Copy link
Member

commented Apr 24, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #76943

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes a bug where dry-run is not honored for pod/eviction sub-resource.

/assign @liggitt

@apelisse apelisse force-pushed the apelisse:fix-dry-run-eviction branch from 257698f to 37f2663 Apr 24, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Apr 24, 2019

@apelisse

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

Updated, PTAL

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

/lgtm
/approve
/sig api-machinery
/priority important-soon

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 28172ec into kubernetes:master Apr 25, 2019

20 checks passed

cla/linuxfoundation apelisse authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@apelisse

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

I'll cherry-pick this to the relevant branches (probably 1.13, 1.14)

k8s-ci-robot added a commit that referenced this pull request May 21, 2019
Merge pull request #77236 from apelisse/automated-cherry-pick-of-#769…
…69-upstream-release-1.14

Automated cherry pick of #76969: Fix eviction dry-run
k8s-ci-robot added a commit that referenced this pull request May 30, 2019
Merge pull request #77234 from apelisse/automated-cherry-pick-of-#769…
…69-upstream-release-1.13

Automated cherry pick of #76969: Fix eviction dry-run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.