Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify azure file share name in azure file plugin #76988

Merged
merged 1 commit into from Apr 24, 2019

Conversation

@andyzhangx
Copy link
Member

commented Apr 24, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR let user

  • could specify azure file share name in azure file plugin
  • use existing azure file share in azure file plugin
---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: azurefile
provisioner: kubernetes.io/azure-file
parameters:
  skuName: Standard_LRS
  resourceGroup: EXISTING_RESOURCE_GROUP_NAME
  storageAccount: EXISTING_STORAGE_ACCOUNT_NAME
  shareName: SHARE_NAME

Which issue(s) this PR fixes:

Fixes #76986

Special notes for your reviewer:
add shareName param in azure file storage class

Release note:

specify azure file share name in azure file plugin

/kind bug
/assign @feiskyer
/priority important-soon
/sig azure

/test pull-kubernetes-e2e-aks-engine-azure

add shareName param in azure file storage class
skip create azure file if it exists
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from brendandburns and rootfs Apr 24, 2019

@andyzhangx andyzhangx changed the title user could specify azure file share name in azure file plugin specify azure file share name in azure file plugin Apr 24, 2019

@feiskyer
Copy link
Member

left a comment

/lgtm

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 24, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 2e96bf5 into kubernetes:master Apr 24, 2019

21 checks passed

cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@feiskyer feiskyer added this to Done in Provider Azure Apr 25, 2019

k8s-ci-robot added a commit that referenced this pull request Apr 27, 2019
Merge pull request #77110 from andyzhangx/automated-cherry-pick-of-#7…
…6988-upstream-release-1.12

Automated cherry pick of #76988: add shareName param in azure file storage class
k8s-ci-robot added a commit that referenced this pull request May 2, 2019
Merge pull request #77042 from andyzhangx/automated-cherry-pick-of-#7…
…6988-upstream-release-1.14

Automated cherry pick of #76988: add shareName param in azure file storage class
k8s-ci-robot added a commit that referenced this pull request May 3, 2019
Merge pull request #77043 from andyzhangx/automated-cherry-pick-of-#7…
…6988-upstream-release-1.13

Automated cherry pick of #76988: add shareName param in azure file storage class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.