Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum docker version to 1.13.1 in kubeadm #77051

Merged
merged 1 commit into from Apr 26, 2019

Conversation

@chenzhiwei
Copy link
Contributor

commented Apr 25, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump minimum docker version to 1.13.1, as Kubernetes bumped in #72831

Which issue(s) this PR fixes:

Related to: #72831

Special notes for your reviewer:

/area kubeadm
sig/cluster-lifecycle

/assign @yagonobre
/assign @neolit123

Does this PR introduce a user-facing change?:

kubeadm: bump the minimum supported Docker version to 1.13.1
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Hi @chenzhiwei. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123
Copy link
Member

left a comment

/hold
/approve
/ok-to-test
/priority important-longterm

@chenzhiwei thanks
please add a release note instead of NONE
kubeadm: bump the minimum supported Docker version to 1.13.1

@kubernetes/sig-cluster-lifecycle-pr-reviews
this is something i requested because the core no longer supports <1.13 and kubeadm is behind.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenzhiwei, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chenzhiwei

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

@neolit123 Updated with the release note, thanks.

@chenzhiwei chenzhiwei force-pushed the chenzhiwei:bump-docker-version branch from d742b59 to d4aaacf Apr 25, 2019

@neolit123

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

/retest

@chenzhiwei

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

/assign @rosti

Could you review this PR?

@neolit123
Copy link
Member

left a comment

merging on lazy consensus.
the dockershim has 1.13 as the minimum already.
/lgtm
/aprove
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Apr 26, 2019

@k8s-ci-robot k8s-ci-robot merged commit 59a8682 into kubernetes:master Apr 26, 2019

20 checks passed

cla/linuxfoundation chenzhiwei authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.