Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rancher Credential Provider from upstream kubernetes #77099

Conversation

@dims
Copy link
Member

commented Apr 25, 2019

This is useful only in rancher environment, they are using this in a
very old branch (1.6), they are currently at 2.2.x. There is just no
point in us carrying this code as this is not useful to anyone else
outside of the rancher environment. Let us please remove this code from
upstream.

Change-Id: I5196d0edd79a7809c3a04e6028ddbd01063f224b

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #77098

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Rancher credential provider has now been removed
@dims

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

/assign @wlan0
cc @alena1108
/sig cloud-provider
/area cloud-provider

@dims

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

/priority important-soon

@dims

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

/assign @deads2k @liggitt

@dims

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

do we have an explicit ack that this is unused in current rancher deployments?

@dims

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

@dims dims force-pushed the dims:remove-rancher-credential-provider-from-upstream-kubernetes branch from de3ce31 to 56a6733 Apr 25, 2019

@dims dims force-pushed the dims:remove-rancher-credential-provider-from-upstream-kubernetes branch from 56a6733 to 61baa13 Apr 25, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

I found it a little hard to tell from that if that was an official ack. Are we certain this is unused?

@alena1108

This comment has been minimized.

Copy link

commented Apr 25, 2019

@liggitt I work for Rancher, and this code leverages an older - 1.x - version of the product. We are planning to maintain it for some time, but it's ok to remove the Rancher credential provider code from the upstream k8s. We can maintain it in our own k8s fork.

Remove Rancher Credential Provider from upstream kubernetes
This is useful only in rancher environment, they are using this in a
very old branch (1.6), they are currently at 2.2.x. There is just no
point in us carrying this code as this is not useful to anyone else
outside of the rancher environment. Let us please remove this code from
upstream.

Change-Id: I5196d0edd79a7809c3a04e6028ddbd01063f224b

@dims dims force-pushed the dims:remove-rancher-credential-provider-from-upstream-kubernetes branch from 61baa13 to edf8577 Apr 25, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

/lgtm
/approve
per #77099 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 26, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 26, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 2776cc1 into kubernetes:master Apr 26, 2019

20 checks passed

cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.