Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta/v1 Table and PartialObjectMetadata objects #77136

Merged

Conversation

@smarterclayton
Copy link
Contributor

commented Apr 26, 2019

Part of promoting server side retrieval to GA.

/kind api-change

Promote meta.k8s.io/v1beta1 Table and PartialObjectMetadata to v1.
@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

/assign @liggitt

@smarterclayton smarterclayton force-pushed the smarterclayton:add_v1_table_partial branch from d7e656a to 36a61b1 Apr 26, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 26, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@smarterclayton smarterclayton force-pushed the smarterclayton:add_v1_table_partial branch from 36a61b1 to 3d37513 Apr 26, 2019

@smarterclayton smarterclayton force-pushed the smarterclayton:add_v1_table_partial branch 2 times, most recently from 7e581b9 to 2d18512 Apr 26, 2019

@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@lavalamp as well knowing that Jordan is busy.

This clones the APIs into v1, then changes the protobuf ids for v1 PartialObjectMetadataList to be consistent with others (we realized in 1.15 that v1beta1 was lacking ListMeta, so Items had already claimed id 1). In v1 the ids are flipped but we don't depend on proto ids for conversion and we don't store partial object metadata list.

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

/assign @lavalamp

@smarterclayton smarterclayton force-pushed the smarterclayton:add_v1_table_partial branch from 2d18512 to f85b930 Apr 30, 2019

@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

Pushed an update, I think I got all the comments.

@smarterclayton smarterclayton force-pushed the smarterclayton:add_v1_table_partial branch from f85b930 to 114a92a Apr 30, 2019

@lavalamp

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

/approve

/retest

@smarterclayton smarterclayton force-pushed the smarterclayton:add_v1_table_partial branch from 114a92a to f6f4200 May 1, 2019

Add meta/v1 Table and PartialObjectMetadata objects
Part of promoting server side retrieval to GA.

@smarterclayton smarterclayton force-pushed the smarterclayton:add_v1_table_partial branch from f6f4200 to f95f1db May 1, 2019

@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

/retest

1 similar comment
@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

/retest

@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

OK, back to green with feedback addressed.

@liggitt

This comment has been minimized.

Copy link
Member

commented May 2, 2019

/lgtm
/approve
/priority important-soon

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ba28e0e into kubernetes:master May 2, 2019

20 checks passed

cla/linuxfoundation smarterclayton authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.