Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the key of invalid label's value in error message #77144

Merged

Conversation

@kenegozi
Copy link
Contributor

commented Apr 26, 2019

For e.g., when specifying an invalid value for a label, it is not always
clear which label the value was specified for. Including the key in the
error message makes debugging easier.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

When specifying an invalid value for a label, it was not always
clear which label the value was specified for. Starting with this release, the
label's key is included in such error messages, which makes debugging easier.
Include the key of invalid label's value in error message
For e.g., when specifying an invalid value for a label, it is not always
clear which label the value was specified for. Including the key in the
error message makes debugging easier.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

Hi @kenegozi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kenegozi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

When specifying an invalid value for a label, it was not always
clear which label the value was specified for. Starting with this release, the
label's key is included in such error messages, which makes debugging easier.```
@kenegozi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

/assign @caesarxuchao

@kenegozi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

Not sure about kind, should a clearer user visible error message be counter as documentation?

@logicalhan
Copy link
Contributor

left a comment

This seems reasonable to me.

/lgtm

@neolit123
Copy link
Member

left a comment

/ok-to-test
/kind cleanup
/priority backlog

@kenegozi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2019

Thanks for taking a look at this.

I copied the release note block from the in-discussion comment to the top comment, in hope it would now get picked up.

@caesarxuchao

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

lgtm

@kenegozi

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Are there any more steps I need to do for this PR to be merged?

@caesarxuchao

This comment has been minimized.

Copy link
Member

commented May 7, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, kenegozi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 167bc95 into kubernetes:master May 7, 2019

20 checks passed

cla/linuxfoundation kenegozi authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@kenegozi

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Thanks for the guidance and for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.