Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for kube-proxy to wait for some duration for the node to be defined. #77167

Merged
merged 3 commits into from Aug 10, 2019

Conversation

@paulsubrata55
Copy link
Contributor

commented Apr 27, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:
Kube-proxy must atleast wait for some duration for the node to defined so that it can fetch the node IP. This node IP is currently used in ipvs proxier for the node-port services.

Which issue(s) this PR fixes:
Fixes #37414

Does this PR introduce a user-facing change?:
NONE

Improvement in Kube-proxy. Kube-proxy waits for some duration for the node to be defined.
Fix for kube-proxy to wait for some duration for the node to be defined
Kube-proxy must atleast wait for some duration for the node to defined so that it can fetch the node IP. This node IP is currently used in ipvs proxier for the node-port services.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

Hi @paulsubrata55. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulsubrata55

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

/assign bowei

func GetNodeIP(client clientset.Interface, hostname string) net.IP {
var nodeIP net.IP
node, err := client.CoreV1().Nodes().Get(hostname, metav1.GetOptions{})
if err != nil {

This comment has been minimized.

Copy link
@JieJhih

JieJhih May 23, 2019

Member

I think it can try to get node at first.
If error then use ExponentialBackoff.

This comment has been minimized.

Copy link
@paulsubrata55

paulsubrata55 May 23, 2019

Author Contributor

Can't we avoid adding same piece of codes present inside ExponentialBackoff's func for getting node and nodeIP here. I don't see any advantage of keeping them outside. ExponentialBackoff will execute the func without any delay for the 1st time and if it passes, it will break the loop the immediately.

@vllry

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

/kind bug
/ok-to-test

@paulsubrata55

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

/retest

@paulsubrata55

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

/test pull-kubernetes-integration

1 similar comment
@paulsubrata55

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

/test pull-kubernetes-integration

@paulsubrata55

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

/assign @thockin

@thockin

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

This probably warrants a release note. Can you please add something short?

@thockin

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 9, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulsubrata55, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paulsubrata55

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit c8c9d2e into kubernetes:master Aug 10, 2019

20 checks passed

cla/linuxfoundation paulsubrata55 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 10, 2019

@paulsubrata55 paulsubrata55 deleted the paulsubrata55:spaul-kube-proxy-fix branch Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.