Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions: implement structural schema condition #77207

Merged
merged 7 commits into from May 9, 2019

Conversation

@sttts
Copy link
Contributor

commented Apr 29, 2019

Imlement KEP https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190425-structural-openapi.md.

* Add a condition NonStructuralSchema to CustomResourceDefinition listing Structural Schema violations as defined in KEP https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190425-structural-openapi.md. CRD authors should update their validation schemas to be structural in order to participate in future CRD features.
* CRD validation schemas get support for `x-kubernetes-embedded-resource: true` to specify `RawExtensions` in OpenAPI and to enforce coercing and validation of TypeMeta and ObjectMeta.
* CRD validation schemas get support for `x-kubernetes-int-or-string: true` to specify `intstr.IntOrString` in OpenAPI.
* CRD validation schemas get support for `x-kubernetes-preserve-unknown-fields: true` to control pruning via OpenAPI for parts of CustomResources.
@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@k8s-ci-robot k8s-ci-robot requested review from deads2k and pmorie Apr 29, 2019

@sttts sttts force-pushed the sttts:sttts-structural-schema branch 2 times, most recently from 96eb99f to 63c66f4 Apr 29, 2019

@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/XL labels Apr 29, 2019

@sttts sttts force-pushed the sttts:sttts-structural-schema branch 2 times, most recently from dd6464d to be95689 Apr 29, 2019

@sttts sttts added this to the v1.15 milestone Apr 29, 2019

@liggitt liggitt added this to Assigned in API Reviews Apr 29, 2019

@sttts sttts force-pushed the sttts:sttts-structural-schema branch from be95689 to 67e54c1 Apr 29, 2019

@sttts sttts changed the title WIP: apiextensions: add structural schema support apiextensions: add structural schema support Apr 29, 2019

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@apelisse @liggitt this is ready for a first review.

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

thanks, will look after KEP deadline tomorrow night... working on getting everything reviewed for that

@liggitt

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label May 9, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented May 9, 2019

immediate follow-ups:

  • round trip testing (#77667)
  • limit metadata to name/generateName validation (#77653)

@sttts sttts force-pushed the sttts:sttts-structural-schema branch from 6e64994 to 01ab300 May 9, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 9, 2019

@sttts sttts added the lgtm label May 9, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented May 9, 2019

saw the vet error

/lgtm

@apelisse

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/assign @jennybuckley

@liggitt liggitt moved this from Changes requested to Completed, 1.15 in API Reviews May 9, 2019

@sttts sttts force-pushed the sttts:sttts-structural-schema branch from 01ab300 to c836a25 May 9, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 9, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 9, 2019

@k8s-ci-robot k8s-ci-robot merged commit 8efea56 into kubernetes:master May 9, 2019

20 checks passed

cla/linuxfoundation sttts authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@sttts sttts deleted the sttts:sttts-structural-schema branch May 10, 2019

@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.