Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add etag for NSG updates so as to fix nsg race condition #77210

Merged
merged 2 commits into from May 3, 2019

Conversation

@feiskyer
Copy link
Member

commented Apr 29, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug
/sig azure
/priority important-soon

What this PR does / why we need it:

The first part of #75582: Add etag for NSG updates so as to fix network security group race condition. With these changes, cloud provider won't override concurrent NSG updates from other components.

Which issue(s) this PR fixes:

Part of #75582.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add etag for NSG updates so as to fix nsg race condition
@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Apr 29, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer feiskyer force-pushed the feiskyer:nsg-race branch from 9ff8647 to 30f1bf2 Apr 29, 2019

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

/retest

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

@feiskyer feiskyer added this to In progress in Provider Azure via automation Apr 30, 2019

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

@andyzhangx @justaugustus Any more comments on this?

@justaugustus

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Looks good, @feiskyer!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label May 3, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5f6d9b6 into kubernetes:master May 3, 2019

20 checks passed

cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

Provider Azure automation moved this from In progress to Done May 3, 2019

@feiskyer feiskyer deleted the feiskyer:nsg-race branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.