Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix ACR MSI cross-subscription authentication error #77245
What type of PR is this?
What this PR does / why we need it:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: no user-facing change
Hi @norshtein. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
If the credential type is MSI, it will interact with MSI endpoint to get a token and write the token to
for the unit test, I think you could move following code into a seperate function, e.g.
Then you could add all kinds of unit tests, that would be testable
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing