Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve existing namespace when using kubectl set --local #77267

Merged
merged 1 commit into from Apr 30, 2019

Conversation

@liggitt
Copy link
Member

commented Apr 30, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Uses existing namespace info in manifests to determine whether to preserve namespace info when running commands locally without RESTMapper info

Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#639

Does this PR introduce a user-facing change?:

Preserves existing namespace information in manifests when running `kubectl set ... --local` commands

/sig cli
/cc @seans3

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seans3

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

/retest

@seans3

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 30, 2019

@k8s-ci-robot k8s-ci-robot merged commit 1e01523 into kubernetes:master Apr 30, 2019

20 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:kubectl-set-local-namespace branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.