Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block volume expansion #77317

Merged
merged 1 commit into from May 2, 2019

Conversation

@gnufied
Copy link
Member

commented May 1, 2019

Fix block volume expansion.

Fixes #77294

/sig storage

cc @leakingtapan @msau42

Fix bug with block volume expansion
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from jingxu97 and msau42 May 1, 2019

@gnufied gnufied changed the title Fix blockvolume expansion Fix block volume expansion May 1, 2019

@gnufied gnufied force-pushed the gnufied:fix-block-volume-resizing branch from 3a79596 to 0eb68c5 May 1, 2019

@gnufied

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

/retest

@gnufied

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

/test pull-kubernetes-integration

It("should allow expansion of block volumes", func() {
pvc, storageClassVar, err = setupFunc(true /*allowExpansion*/, true /*blockVolume*/)

By("Waiting for pvc to be in bound phase")

This comment has been minimized.

Copy link
@msau42

msau42 May 2, 2019

Member

fyi, when moving these tests to the framework, they will need to be able to handle delayed binding, so the pod needs to be created first.

@msau42

This comment has been minimized.

Copy link
Member

commented May 2, 2019

/lgtm
/priority important-soon
/kind bug

@k8s-ci-robot k8s-ci-robot merged commit 9e52832 into kubernetes:master May 2, 2019

20 checks passed

cla/linuxfoundation gnufied authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.