Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require version match to special-case status objects #77368

Merged
merged 1 commit into from May 3, 2019

Conversation

@liggitt
Copy link
Member

commented May 2, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes incorrect handling of objects whose Kind happens to be "Status"

Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#186

Does this PR introduce a user-facing change?:

Fixes incorrect handling by kubectl of custom resources whose Kind is "Status"
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

parallels special case logic at

if status.APIVersion != "v1" && status.APIVersion != "meta.k8s.io/v1" {
break
}

@k8s-ci-robot k8s-ci-robot requested review from juanvallejo and seans3 May 2, 2019

@seans3
Copy link
Contributor

left a comment

This looks good. Should we take the opportunity to add a unit test to scheme.go? If not in this PR, I will add one later.

@liggitt liggitt force-pushed the liggitt:handle-status-objects branch from f459f83 to dbe6128 May 3, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/S labels May 3, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

yeah, added a test

@liggitt

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

/priority important-soon

@seans3

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

/lgtm
Thanks for the test.

@k8s-ci-robot k8s-ci-robot added the lgtm label May 3, 2019

@k8s-ci-robot k8s-ci-robot merged commit 5bbad4f into kubernetes:master May 3, 2019

20 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:handle-status-objects branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.