Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
create new SCTP ipsets for IPVS proxier #77371
Signed-off-by: Andrew Sy Kim firstname.lastname@example.org
What type of PR is this?
What this PR does / why we need it:
This PR adds a new ipset
Shout out to @lbernail for finding the bug :)
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
May 2, 2019
Thank you for the PR!
I think the safest approach is alternative 1 (new name) because even if we find a solution for upgrading to 1.15, some people might need to rollback to a previous version which will fail because there will be a
It's not perfect because we will leave an unuset ipset behind (maybe we can provide clean up logic in 1.15.x and make a note to remove it in 1.16 for instance?)
Good point, this would not be rollback safe. I'll add a new ipset for this then.
TBH I think we should just leave it. I don't see risk in leaving the ipset there, especially with the name
I really don't have a strong opinion. If we were to do that we would have to remember to remove the additional logic later. I agree it's not a real problem
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing