New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add containerized option to kubelet binary #7741

Merged
merged 1 commit into from May 4, 2015

Conversation

Projects
None yet
4 participants
@pmorie
Member

pmorie commented May 4, 2015

@vmarmol PTAL

@googlebot googlebot added the cla: yes label May 4, 2015

Show outdated Hide outdated cmd/kubelet/app/server.go
@@ -213,6 +215,7 @@ func (s *KubeletServer) AddFlags(fs *pflag.FlagSet) {
// Flags intended for testing, not recommended used in production environments.
fs.BoolVar(&s.ReallyCrashForTesting, "really-crash-for-testing", s.ReallyCrashForTesting, "If true, when panics occur crash. Intended for testing.")
fs.Float64Var(&s.ChaosChance, "chaos-chance", s.ChaosChance, "If > 0.0, introduce random client errors and latency. Intended for testing. [default=0.0]")
fs.BoolVar(&s.Containerized, "containerized", s.Containerized, "Experimental support for running kubelet in a container. Intended for testing.")

This comment has been minimized.

@vmarmol

vmarmol May 4, 2015

Contributor

nit: add "Default: false"

@vmarmol

vmarmol May 4, 2015

Contributor

nit: add "Default: false"

@vmarmol

This comment has been minimized.

Show comment
Hide comment
@vmarmol

vmarmol May 4, 2015

Contributor

LGTM

Contributor

vmarmol commented May 4, 2015

LGTM

@pmorie

This comment has been minimized.

Show comment
Hide comment
@pmorie

pmorie May 4, 2015

Member

@vmarmol Fixed

Member

pmorie commented May 4, 2015

@vmarmol Fixed

@vmarmol

This comment has been minimized.

Show comment
Hide comment
@vmarmol

vmarmol May 4, 2015

Contributor

Thanks @pmorie! Will merge on green.

Contributor

vmarmol commented May 4, 2015

Thanks @pmorie! Will merge on green.

@vmarmol vmarmol self-assigned this May 4, 2015

@vmarmol vmarmol added the lgtm label May 4, 2015

@pmorie

This comment has been minimized.

Show comment
Hide comment
@pmorie

pmorie May 4, 2015

Member

@vmarmol tomorrow I'll do PRs for the image and local-up-cluster accommodation for this use-case

Member

pmorie commented May 4, 2015

@vmarmol tomorrow I'll do PRs for the image and local-up-cluster accommodation for this use-case

vmarmol added a commit that referenced this pull request May 4, 2015

Merge pull request #7741 from pmorie/containerized
Add containerized option to kubelet binary

@vmarmol vmarmol merged commit 9340b7a into kubernetes:master May 4, 2015

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Shippable Shippable builds completed
Details
cla/google All necessary CLAs are signed
@vmarmol

This comment has been minimized.

Show comment
Hide comment
@vmarmol

vmarmol May 4, 2015

Contributor

Awesome! Merged :)

Contributor

vmarmol commented May 4, 2015

Awesome! Merged :)

@ixdy

This comment has been minimized.

Show comment
Hide comment
@ixdy

ixdy May 4, 2015

Member

This PR broke the non-linux builds:

+++ [0504 23:19:57] darwin/amd64: go build started
# github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app
_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app/server.go:280: undefined: mount.NsenterMounter
!!! Error in /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340
  'go install "${goflags[@]:+${goflags[@]}}" -ldflags "${version_ldflags}" "${nonstatics[@]:+${nonstatics[@]}}"' exited with status 2
Call stack:
  1: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340 kube::golang::build_binaries_for_platform(...)
  2: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:446 kube::golang::build_binaries(...)
  3: hack/build-cross.sh:31 main(...)
Exiting with status 1
+++ [0504 23:19:57] darwin/386: go build started
# github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app
_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app/server.go:280: undefined: mount.NsenterMounter
!!! Error in /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340
  'go install "${goflags[@]:+${goflags[@]}}" -ldflags "${version_ldflags}" "${nonstatics[@]:+${nonstatics[@]}}"' exited with status 2
Call stack:
  1: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340 kube::golang::build_binaries_for_platform(...)
  2: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:446 kube::golang::build_binaries(...)
  3: hack/build-cross.sh:31 main(...)
Exiting with status 1
+++ [0504 23:19:57] windows/amd64: go build started
# github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app
_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app/server.go:280: undefined: mount.NsenterMounter
!!! Error in /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340
  'go install "${goflags[@]:+${goflags[@]}}" -ldflags "${version_ldflags}" "${nonstatics[@]:+${nonstatics[@]}}"' exited with status 2
Call stack:
  1: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340 kube::golang::build_binaries_for_platform(...)
  2: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:446 kube::golang::build_binaries(...)
  3: hack/build-cross.sh:31 main(...)
Exiting with status 1
Member

ixdy commented May 4, 2015

This PR broke the non-linux builds:

+++ [0504 23:19:57] darwin/amd64: go build started
# github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app
_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app/server.go:280: undefined: mount.NsenterMounter
!!! Error in /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340
  'go install "${goflags[@]:+${goflags[@]}}" -ldflags "${version_ldflags}" "${nonstatics[@]:+${nonstatics[@]}}"' exited with status 2
Call stack:
  1: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340 kube::golang::build_binaries_for_platform(...)
  2: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:446 kube::golang::build_binaries(...)
  3: hack/build-cross.sh:31 main(...)
Exiting with status 1
+++ [0504 23:19:57] darwin/386: go build started
# github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app
_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app/server.go:280: undefined: mount.NsenterMounter
!!! Error in /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340
  'go install "${goflags[@]:+${goflags[@]}}" -ldflags "${version_ldflags}" "${nonstatics[@]:+${nonstatics[@]}}"' exited with status 2
Call stack:
  1: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340 kube::golang::build_binaries_for_platform(...)
  2: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:446 kube::golang::build_binaries(...)
  3: hack/build-cross.sh:31 main(...)
Exiting with status 1
+++ [0504 23:19:57] windows/amd64: go build started
# github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app
_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/app/server.go:280: undefined: mount.NsenterMounter
!!! Error in /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340
  'go install "${goflags[@]:+${goflags[@]}}" -ldflags "${version_ldflags}" "${nonstatics[@]:+${nonstatics[@]}}"' exited with status 2
Call stack:
  1: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:340 kube::golang::build_binaries_for_platform(...)
  2: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:446 kube::golang::build_binaries(...)
  3: hack/build-cross.sh:31 main(...)
Exiting with status 1

@justinsb justinsb referenced this pull request May 4, 2015

Closed

OSX build broken (?) #7747

@vmarmol

This comment has been minimized.

Show comment
Hide comment
@vmarmol

vmarmol May 4, 2015

Contributor

Grr sorry @ixdy. @pmorie we need to add the stub version for non-Linux systems.

Will revert and we'll try again. Thanks for the notice!

Contributor

vmarmol commented May 4, 2015

Grr sorry @ixdy. @pmorie we need to add the stub version for non-Linux systems.

Will revert and we'll try again. Thanks for the notice!

@pmorie

This comment has been minimized.

Show comment
Hide comment
@pmorie

pmorie May 4, 2015

Member

Dang
On Mon, May 4, 2015 at 7:34 PM Victor Marmol notifications@github.com
wrote:

Grr sorry @ixdy https://github.com/ixdy. @pmorie
https://github.com/pmorie we need to add the stub version for non-Linux
systems.

Will revert and we'll try again. Thanks for the notice!


Reply to this email directly or view it on GitHub
#7741 (comment)
.

Member

pmorie commented May 4, 2015

Dang
On Mon, May 4, 2015 at 7:34 PM Victor Marmol notifications@github.com
wrote:

Grr sorry @ixdy https://github.com/ixdy. @pmorie
https://github.com/pmorie we need to add the stub version for non-Linux
systems.

Will revert and we'll try again. Thanks for the notice!


Reply to this email directly or view it on GitHub
#7741 (comment)
.

@pmorie

This comment has been minimized.

Show comment
Hide comment
@pmorie

pmorie May 4, 2015

Member

My bad! I will fix
On Mon, May 4, 2015 at 7:43 PM Paul Morie pmorie@gmail.com wrote:

Dang
On Mon, May 4, 2015 at 7:34 PM Victor Marmol notifications@github.com
wrote:

Grr sorry @ixdy https://github.com/ixdy. @pmorie
https://github.com/pmorie we need to add the stub version for
non-Linux systems.

Will revert and we'll try again. Thanks for the notice!


Reply to this email directly or view it on GitHub
#7741 (comment)
.

Member

pmorie commented May 4, 2015

My bad! I will fix
On Mon, May 4, 2015 at 7:43 PM Paul Morie pmorie@gmail.com wrote:

Dang
On Mon, May 4, 2015 at 7:34 PM Victor Marmol notifications@github.com
wrote:

Grr sorry @ixdy https://github.com/ixdy. @pmorie
https://github.com/pmorie we need to add the stub version for
non-Linux systems.

Will revert and we'll try again. Thanks for the notice!


Reply to this email directly or view it on GitHub
#7741 (comment)
.

@vmarmol

This comment has been minimized.

Show comment
Hide comment
@vmarmol

vmarmol May 4, 2015

Contributor

No worries, should have caught it in review. Also, we're not running build cross in CI? Let me look into fixing that.

Contributor

vmarmol commented May 4, 2015

No worries, should have caught it in review. Also, we're not running build cross in CI? Let me look into fixing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment