Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define kubeconfig file for OpenStack cloud provider #77415

Merged
merged 1 commit into from May 8, 2019

Conversation

@Fedosin
Copy link
Contributor

commented May 3, 2019

Now, to build a kubernetes client, provider uses only in-cluster config,
but if kubelet is not running as a pod, then it doesn't work.

This commit adds an ability to specify a path to the kubeconfig file if
necessary. If no value was provided, then the provider falls back to
in-cluster config.

/kind feature

Allow to define kubeconfig file for OpenStack cloud provider.
@Fedosin

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

/test pull-kubernetes-verify

Allow to define kubeconfig file for OpenStack cloud provider
Now, to build a kubernetes client, provider uses only in-cluster config,
but if kubelet is not running as a pod, then it doesn't work.

This commit adds an ability to specify a path to the kubeconfig file if
necessary. If no value was provided, then the provider falls back to
in-cluster config.

@Fedosin Fedosin force-pushed the Fedosin:allow_define_kubeconfig branch from 2f5d70c to bac2291 May 4, 2019

@FengyunPan2
Copy link
Contributor

left a comment

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, FengyunPan2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adisky

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 8, 2019

@k8s-ci-robot k8s-ci-robot merged commit 291f2f8 into kubernetes:master May 8, 2019

20 checks passed

cla/linuxfoundation Fedosin authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@Fedosin Fedosin deleted the Fedosin:allow_define_kubeconfig branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.