Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify apimachinery,apps,instrumentation tests to import framework/log #77425

Merged
merged 1 commit into from May 9, 2019

Conversation

@figo
Copy link
Member

commented May 3, 2019

This is part of the transition to using framework/log instead
of the Logf inside the framework package. This will help with
import size/cycles when importing the framework or subpackages

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
#77359

N/A
@figo

This comment has been minimized.

Copy link
Member Author

commented May 4, 2019

/assign @andrewsykim

@andrewsykim

This comment has been minimized.

Copy link
Member

commented May 4, 2019

/priority important-longterm
/area e2e-test-framework

@figo

This comment has been minimized.

Copy link
Member Author

commented May 4, 2019

/test pull-kubernetes-integration

@oomichi

This comment has been minimized.

Copy link
Member

commented May 6, 2019

/lgtm

@andrewsykim

This comment has been minimized.

Copy link
Member

commented May 6, 2019

/assign @timothysc

@figo

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

a new change on test/e2e/apimachinery/chunking.go checked-in today, i am going to do a force push to resolve the conflict, appreciate if you can add lgtm again @oomichi @andrewsykim @timothysc

@figo figo force-pushed the figo:e2e branch from d390373 to 3c86f35 May 7, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 7, 2019

@oomichi

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@figo Thanks for maintaining this.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 8, 2019

@timothysc
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: figo, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oomichi

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@figo Could you rebase this again, sorry about that.

Modify apimachinery,apps,instrumentation tests to import framework/log
This is part of the transition to using framework/log instead
of the Logf inside the framework package. This will help with
import size/cycles when importing the framework or subpackages

@figo figo force-pushed the figo:e2e branch from 3c86f35 to 4d4e4f4 May 8, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 8, 2019

@figo

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

/test pull-kubernetes-e2e-gce

@figo

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

@figo Could you rebase this again, sorry about that.

thx, rebase done, PTAL @oomichi

@andrewsykim

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 9, 2019

@k8s-ci-robot k8s-ci-robot merged commit ee0038a into kubernetes:master May 9, 2019

20 checks passed

cla/linuxfoundation figo authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.