Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support meta.k8s.io/v1 Table and PartialObjectMetadata requests to the API #77448

Merged
merged 2 commits into from May 11, 2019

Conversation

@smarterclayton
Copy link
Contributor

commented May 4, 2019

Clients may now request responses transformed to the v1 form of the Table and PartialObjectMetadata objects. Internally, the metav1 and metav1beta1 types are identical, except for PartialObjectMetadataList in v1beta1 which has a different, legacy protobuf ID ordering (due to a bug not caught until 1.15).

After this change clients can use the v1 version of the objects.

/kind api-change

Clients may now request that API objects are converted to the `v1.Table` and `v1.PartialObjectMetadata` forms for generic access to objects.
@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented May 4, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@smarterclayton smarterclayton force-pushed the smarterclayton:api_serve branch from 3b77e16 to ef99e95 May 4, 2019

Make metav1beta1 be equivalent to metav1 internally
All except PartialObjectMetadataList are identical and should be made
that way internally. This allows the internalversion to convert between
them.

@smarterclayton smarterclayton force-pushed the smarterclayton:api_serve branch from ef99e95 to f86b896 May 5, 2019

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 6, 2019

/assign

@smarterclayton smarterclayton force-pushed the smarterclayton:api_serve branch 2 times, most recently from 1df1286 to 2d52bed May 7, 2019

@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented May 8, 2019

lgtm. would be good to have tests that accept v1,v1beta1 and v1beta1,v1, and ensure the preferred Content-Type is returned (since we'll switch kubectl to request both shortly, I expect)

@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

lgtm. would be good to have tests that accept v1,v1beta1 and v1beta1,v1, and ensure the preferred Content-Type is returned (since we'll switch kubectl to request both shortly, I expect)

ack

API server should offer metav1 Table/Partial transforms
Now that internal types are equivalent, allow the apiserver to serve
metav1 and metav1beta1 depending on the client. Test that in the
apiserver integration test and ensure we get the appropriate responses.

Register the metav1 type in the appropriate external locations.

@smarterclayton smarterclayton force-pushed the smarterclayton:api_serve branch from 2d52bed to 33a3e32 May 10, 2019

@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Updated, folded the constant in

@liggitt

This comment has been minimized.

Copy link
Member

commented May 11, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 274876e into kubernetes:master May 11, 2019

20 checks passed

cla/linuxfoundation smarterclayton authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.