Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Un-reserve extension point for the scheduling framework #77457

Merged
merged 1 commit into from May 8, 2019

Conversation

@danielqsj
Copy link
Member

commented May 5, 2019

What type of PR is this?

/kind feature
/sig scheduling

What this PR does / why we need it:

Add Un-reserve extension point for the scheduling framework

Which issue(s) this PR fixes:

Fixes #77288

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Implement un-reserve extension point for the scheduling framework.
@danielqsj

This comment has been minimized.

Copy link
Member Author

commented May 5, 2019

/assign @bsalamat

@bsalamat
Copy link
Member

left a comment

Thanks, @danielqsj!

Show resolved Hide resolved pkg/scheduler/framework/v1alpha1/interface.go Outdated
Show resolved Hide resolved pkg/scheduler/framework/v1alpha1/framework.go Outdated
Show resolved Hide resolved pkg/scheduler/framework/v1alpha1/interface.go Outdated
Show resolved Hide resolved test/integration/scheduler/framework_test.go Outdated
Show resolved Hide resolved test/integration/scheduler/framework_test.go Outdated

@danielqsj danielqsj force-pushed the danielqsj:un-reserve branch from 57d6cc0 to e84b042 May 7, 2019

@danielqsj

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

@bsalamat Thanks for your review. Comments addressed. PTAL

@danielqsj danielqsj force-pushed the danielqsj:un-reserve branch 3 times, most recently from 63762de to 6bdac37 May 7, 2019

@danielqsj danielqsj force-pushed the danielqsj:un-reserve branch from 6bdac37 to 8b51825 May 7, 2019

@bsalamat
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label May 7, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, danielqsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bsalamat

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Thanks, @danielqsj!

@k8s-ci-robot k8s-ci-robot merged commit 1ce103a into kubernetes:master May 8, 2019

20 checks passed

cla/linuxfoundation danielqsj authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@liggitt

This comment has been minimized.

Copy link
Member

commented on test/integration/scheduler/framework_test.go in 8b51825 May 8, 2019

this test is flaking. see #77573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.