Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add operation name for vm/vmss update operations in prometheus metrics #77491

Merged
merged 1 commit into from May 13, 2019

Conversation

@andyzhangx
Copy link
Member

commented May 6, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Current we cannot know whether it's attach/detach disk in prometheous metric, and even in vmss update, it also contains network update, this PR add a new parameter(operation) to get rid of this

# curl http://localhost:10252/metrics | grep cloudprovider_azure_api_request | grep -e sum -e count | grep disk
 
cloudprovider_azure_api_request_duration_seconds_sum{request="vmssvm_create_or_update",resource_group="andy-vmss1141",source="attach_disk",subscription_id="b9d2281e-dcd5-4dfd-9a97-xxx"} 1335.532763361
cloudprovider_azure_api_request_duration_seconds_count{request="vmssvm_create_or_update",resource_group="andy-vmss1141",source="attach_disk",subscription_id="b9d2281e-dcd5-4dfd-9a97-xxx"} 6
cloudprovider_azure_api_request_duration_seconds_sum{request="vmssvm_create_or_update",resource_group="andy-vmss1141",source="detach_disk",subscription_id="b9d2281e-dcd5-4dfd-9a97-xxx"} 1577.4697504959997
cloudprovider_azure_api_request_duration_seconds_count{request="vmssvm_create_or_update",resource_group="andy-vmss1141",source="detach_disk",subscription_id="b9d2281e-dcd5-4dfd-9a97-xxx"} 7

This PR also removes a useless function: CreateOrUpdateVMWithRetry

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add operation name for vm/vmss update operations in prometheus metrics

/assign @feiskyer
/priority important-soon
/sig azure

add source in azure metrics
add source in azure metrics

revert back zz_generated.conversion.go

@andyzhangx andyzhangx force-pushed the andyzhangx:azuredisk-metrics branch from b4949e4 to 00c972c May 10, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels May 10, 2019

@andyzhangx andyzhangx changed the title add opration name for vm/vmss update operations in prometheus metrics add operation name for vm/vmss update operations in prometheus metrics May 10, 2019

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

/test pull-kubernetes-e2e-aks-engine-azure
@feiskyer PTAL

@feiskyer
Copy link
Member

left a comment

/lgtm
/approve
/test

@k8s-ci-robot k8s-ci-robot added the lgtm label May 13, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member

commented May 13, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@andyzhangx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure 00c972c link /test pull-kubernetes-e2e-aks-engine-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 1c689c2 into kubernetes:master May 13, 2019

20 of 21 checks passed

pull-kubernetes-e2e-aks-engine-azure Job failed.
Details
cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.