Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
add scheduling framework configuration #77501
What type of PR is this?
What this PR does / why we need it:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Hi @JieJhih. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
May 6, 2019
config looks much cleaner, thanks. one question about nesting structure and a couple doc suggestions
edit: the ordering question at https://github.com/kubernetes/kubernetes/pull/77501/files#r285259640 needs to be resolved, since that could affect the shape of the options
This config looks workable. Would be good to make sure there are unit tests covering the scenarios where someone wants to disable a default plugin, or disable all and specify their own order, or include a default plugin in an explicit order
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
@liggitt The logic to disable plugins are not added yet. It will be added later as a separate PR. In fact, we haven't added the logic to define default plugins which is the first step before adding the logic to disable them. When we add that logic later, we will definitely add tests to cover it.