Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new field for storing volume expansion secrets #77516

Merged
merged 1 commit into from May 10, 2019

Conversation

@gnufied
Copy link
Member

commented May 6, 2019

Add a new field for storing volume expansion secrets.

xref: kubernetes/enhancements#831

/sig storage

cc @liggitt @msau42

Add a field to store CSI volume expansion secrets
@fejta-bot

This comment has been minimized.

Copy link

commented May 6, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels May 6, 2019

@gnufied gnufied force-pushed the gnufied:implement-resize-secrets branch from b2b6409 to f81b0fe May 6, 2019

pkg/api/persistentvolume/util.go Outdated Show resolved Hide resolved
pkg/apis/core/types.go Outdated Show resolved Hide resolved
@msau42

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Do we also need to modify ValidatePersistentVolumeUpdate() to allow setting the secret ref?

@gnufied gnufied force-pushed the gnufied:implement-resize-secrets branch from f81b0fe to bacb1f5 May 6, 2019

@gnufied

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

@msau42 yeah agreed, added ability to set ControllerExpandSecretRef if not already set.

@gnufied

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

/priority important-soon

@msau42

This comment has been minimized.

Copy link
Member

commented May 7, 2019

/label api-review

@liggitt liggitt added this to Assigned in API Reviews May 7, 2019

@liggitt liggitt self-assigned this May 7, 2019

@liggitt liggitt moved this from Assigned to In progress in API Reviews May 7, 2019

pkg/apis/core/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/validation.go Outdated Show resolved Hide resolved
pkg/api/persistentvolume/util_test.go Outdated Show resolved Hide resolved
pkg/api/v1/persistentvolume/util.go Outdated Show resolved Hide resolved
pkg/api/v1/persistentvolume/util.go Outdated Show resolved Hide resolved
pkg/api/v1/persistentvolume/util_test.go Outdated Show resolved Hide resolved

@liggitt liggitt moved this from In progress to Changes requested in API Reviews May 7, 2019

@gnufied gnufied force-pushed the gnufied:implement-resize-secrets branch from 0f9c1fb to 3990062 May 8, 2019

@gnufied

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

@liggitt addressed all the comments. PTAL.

@msau42

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Mostly lgtm, just 2 minor comments.

@liggitt

This comment has been minimized.

Copy link
Member

commented May 9, 2019

API changes are approved
/approve

needs a rebase, and agree with @msau42's comments, and squash in review comments before merge

@liggitt liggitt moved this from Changes requested to Completed, 1.15 in API Reviews May 9, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add a new field for storing volume expansion secrets
Fix pv secret visitor tests
Allow SecretRef for resizing to be set if not already set

@gnufied gnufied force-pushed the gnufied:implement-resize-secrets branch from 3990062 to 6939329 May 9, 2019

@gnufied

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

/retest

@msau42

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/lgtm

@gnufied

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3e7fa61 into kubernetes:master May 10, 2019

18 of 20 checks passed

pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
tide Not mergeable. Job pull-kubernetes-e2e-gce-100-performance has not succeeded.
Details
cla/linuxfoundation gnufied authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.