Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use HTTPS as etcd-apiserver protocol when mTLS is enabled #77561
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
@mikedanese thanks for your quick response! I am waiting for @wojtek-t to help to do some performance test. There is performance regression and it is possible that #74690 is one of the cause so we reverted it in #77158. But since there are a lot of PRs at the same period of time so it's hard to tell how much impact does it have if it does cause performance regression. Now I am creating a new PR. And when @wojtek-t has time, he will help to do the GCE-5000 performance test for isolated performance investigation on this one PR. Once we are ready, I will sure ping you, thanks!
@mm4tt it looks like there is still some issue with setting up prometheus stack. This is gce_500 test, and gce_5000 test has passed for this PR. Would you mind helping take another look?
W0724 22:50:28.428] F0724 22:50:28.414485 101549 clusterloader.go:238] Error while setting up prometheus stack: timed out waiting for the condition
referenced this pull request
Jul 25, 2019
This looks reasonable to me, but I would like @mikedanese to also take a look.
For now I'm temporarily holding it - I would like this to merge on Sunday when there are less merges to allow easier comparison on 5k-scalability tests.
Thanks - I though you've run only 2k-node tests. In that case, I'm less concerned.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing