Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Post-bind extension point to the scheduling framework #77567

Conversation

@wgliang
Copy link
Member

commented May 8, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #77566

Special notes for your reviewer:
@bsalamat @k82cn @Huang-Wei

Does this PR introduce a user-facing change?:

Add Post-bind extension point to the scheduling framework

@k8s-ci-robot k8s-ci-robot requested review from bsalamat and Huang-Wei May 8, 2019

@wgliang wgliang force-pushed the wgliang:features/scheduling-framework-post-bind branch from dc09d62 to 4ce5148 May 8, 2019

@wgliang wgliang changed the title [WIP]Add Post-bind extension point to the scheduling framework Add Post-bind extension point to the scheduling framework May 8, 2019

@wgliang wgliang force-pushed the wgliang:features/scheduling-framework-post-bind branch from 4ce5148 to 28a0762 May 8, 2019

@wgliang

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

/priority important-soon
/kind feature

@wgliang wgliang closed this May 8, 2019

@wgliang wgliang force-pushed the wgliang:features/scheduling-framework-post-bind branch from 2bee1d2 to bace505 May 8, 2019

@k8s-ci-robot k8s-ci-robot added size/XS approved and removed size/M labels May 8, 2019

@wgliang wgliang reopened this May 8, 2019

@k8s-ci-robot k8s-ci-robot added size/M and removed size/XS approved labels May 8, 2019

@wgliang wgliang force-pushed the wgliang:features/scheduling-framework-post-bind branch from 34827bd to c336eba May 8, 2019

@wgliang

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

/retest

@wgliang

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

@bsalamat Thanks for your comments, I've updated all. PTAL again

@@ -93,6 +97,14 @@ func (f *framework) RunPrebindPlugins(
return nil
}

// RunPostbindPlugins runs the set of configured postbind plugins.
func (f *framework) RunPostbindPlugins(

This comment has been minimized.

Copy link
@draveness

draveness May 14, 2019

Member

nit: RunPostbindPlugins {

This comment has been minimized.

Copy link
@wgliang

wgliang May 14, 2019

Author Member

Need to pass parameters.

This comment has been minimized.

Copy link
@draveness

draveness May 14, 2019

Member

Sorry, thought it was a bracket

@wgliang wgliang force-pushed the wgliang:features/scheduling-framework-post-bind branch from 2fbb179 to a45b81c May 14, 2019

@wgliang

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot added the lgtm label May 14, 2019

@bsalamat
Copy link
Member

left a comment

/lgtm
/approve
/hold

Thanks, @wgliang!
Let's hold this PR for now until #77501 is merged.

@bsalamat
Copy link
Member

left a comment

/hold cancel
/lgtm cancel

@@ -75,6 +76,9 @@ func NewFramework(r Registry, _ *runtime.Unknown) (Framework, error) {
if pp, ok := p.(PrebindPlugin); ok {
f.prebindPlugins = append(f.prebindPlugins, pp)
}
if pp, ok := p.(PostbindPlugin); ok {

This comment has been minimized.

Copy link
@bsalamat

bsalamat May 18, 2019

Member

Please rebase and follow the new model for initializing plugins.

This comment has been minimized.

Copy link
@wgliang

wgliang May 20, 2019

Author Member

DONE

@wgliang wgliang force-pushed the wgliang:features/scheduling-framework-post-bind branch from a45b81c to 08d76e8 May 19, 2019

@wgliang wgliang force-pushed the wgliang:features/scheduling-framework-post-bind branch 3 times, most recently from 536e6d7 to 1f54d4b May 19, 2019

@wgliang

This comment has been minimized.

Copy link
Member Author

commented May 19, 2019

/test pull-kubernetes-integration

@wgliang wgliang force-pushed the wgliang:features/scheduling-framework-post-bind branch from 1f54d4b to 20f9c99 May 19, 2019

@wgliang

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

/ping @bsalamat PTAL,thanks

@bsalamat
Copy link
Member

left a comment

/lgtm
/approve

Thanks, @wgliang!

@k8s-ci-robot k8s-ci-robot added the lgtm label May 29, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, wgliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented May 29, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit bb475c4 into kubernetes:master May 30, 2019

18 of 21 checks passed

pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
tide Not mergeable. Job pull-kubernetes-e2e-gce-100-performance has not succeeded.
Details
cla/linuxfoundation wgliang authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@wgliang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce-big 20f9c99 link /test pull-kubernetes-kubemark-e2e-gce-big

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@draveness draveness referenced this pull request Jun 3, 2019

Open

Scheduling Framework #624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.