Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 77515 Deprecate the option to enable the log handler for apiserver #77611

Conversation

@rohitsardesai83
Copy link
Contributor

commented May 8, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Deprecate the option to enable the log handler for apiserver.

Which issue(s) this PR fixes:
Fixes #77515

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kube-apiserver: the `--enable-logs-handler` flag and log-serving functionality is deprecated, and scheduled to be removed in v1.19.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Hi @rohitsardesai83. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims

This comment has been minimized.

Copy link
Member

commented May 8, 2019

/ok-to-test
/priority important-soon

@jennybuckley

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

/assign @lavalamp

@liggitt

This comment has been minimized.

Copy link
Member

commented May 22, 2019

I added a release note for this. Please add the specific release we intend to remove the log serving function to the flag deprecation message

@rohitsardesai83 rohitsardesai83 force-pushed the rohitsardesai83:deprecate-logs-handler-apiserver branch from 1d3681f to a50273f May 28, 2019

@rohitsardesai83

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

I added a release note for this. Please add the specific release we intend to remove the log serving function to the flag deprecation message

done , thanks @liggitt !

@liggitt

This comment has been minimized.

Copy link
Member

commented May 28, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, rohitsardesai83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented May 28, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

commented May 29, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@rohitsardesai83

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6e78282 into kubernetes:master May 29, 2019

21 checks passed

cla/linuxfoundation rohitsardesai83 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.