Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress: migrate extensions.Ingress to networking.Ingress #77617

Merged
merged 1 commit into from May 11, 2019

Conversation

@cmluciano
Copy link
Member

commented May 8, 2019

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This is a find/replace within my editor. I made the import
networkingv1beta1 so that it will be easier to replace for
the future v1 migration.

Which issue(s) this PR fixes:
Related: kubernetes/enhancements#758

Special notes for your reviewer:

  • I'm hoping that I hit all of the variations, but it's possible that something got missed.

Does this PR introduce a user-facing change?:
-->

ingress:  Update in-tree Ingress controllers, examples, and clients to target networking.k8s.io/v1beta1
@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

/sig network

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

/assign @liggitt

@cblecker

This comment has been minimized.

Copy link
Member

commented May 8, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from cblecker May 8, 2019

@thockin
Copy link
Member

left a comment

Thanks!

/lgtm
/approve

@fejta-bot

This comment has been minimized.

Copy link

commented May 9, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

I forgot to run the verify tests before submitting, will fix this up tomorrow

/hold

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

strangely make update didn't really do anything.

/hold cancel

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented May 9, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

commented May 10, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

/hold

ingress: migrate extensions.Ingress to networking.Ingress
This is a find/replace within my editor. I made the import
networkingv1beta1 so that it will be easier to replace for
the future v1 migration.

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>

@cmluciano cmluciano force-pushed the cmluciano:cml/extensiontonetworking branch from e5fae68 to d9e4933 May 10, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 10, 2019

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

/hold cancel

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

/test pull-kubernetes-e2e-gce

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

@thockin had to rebase/fixed tests, can I get your lgtm again?

@thockin

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label May 10, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmluciano, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 33f44a2 into kubernetes:master May 11, 2019

20 checks passed

cla/linuxfoundation cmluciano authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.