Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
In GuaranteedUpdate, retry on any error if we are working with cached data #77619
Previously, GuaranteedUpdate only retry with refreshed data on "Conflict" error. This is wrong in general, and causes a specific problem we found in #76346, where an object was deleted by the apiserver even if a previous operation had added finalizer to the object. It's because the
I checked all calls to
Thanks for checking. I found the ways the we're performing reads with GuaranteedUpdate to be generally difficult to reason about and error prone, but maybe that's a topic for another day.
I've walked through the code more carefully and it does fix the issue. I'm in favor of getting it in and backported.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing